Skip to content

fix: adjust contrasts, link names and other accessibility features #107

Jump to bottom
Merged
merged 19 commits into from
Nov 10, 2026
Merged

fix: adjust contrasts, link names and other accessibility features #107

merged 19 commits into from
Nov 10, 2026
+317 −133

Conversation

martakam
Copy link
Member

@martakam martakam commented Nov 7, 2026 •
edited
Loading

This PR attempts to rectify multiple issues highlighted by the automatic checks done by Playwright in order to improve the accessibility of the app.

The documentation for accessibility has also been updated.

Some of the tests in this pull request has been created with the assistance of AI.

Waiting for #108 to be merged first, since this PR will likely need fixes after that is merged.

This PR is to be merged after #106, since it builds further upon that one.

Closes #65

@martakam
Copy link
Member Author

martakam commented Nov 7, 2026

I think this PR should resolve #65, and we can open another issue where we describe where we use divs and spans, because they have their real uses. Would appreciate feedback on this

@martakam martakam self-assigned this Nov 7, 2026
@martakam martakam added the enhancement New feature or request label Nov 7, 2026
@martakam martakam added this to the Deliverable 4 milestone Nov 7, 2026
@martakam martakam mentioned this pull request Nov 8, 2026
Merged
@martakam martakam marked this pull request as ready for review November 8, 2026 18:33
@martakam martakam requested a review from a team as a code owner November 8, 2026 18:34
@johahor
Copy link
Member

johahor commented Nov 10, 2026

Merged #106 into this branch, and updated a outdated test to make sure pnpm test also succeeds. Tested with pnpm e2e, and it works fine. Got 15 errors which I think we can, and should deal with in a separate smaller PR. Approving, with a link to the new issue.

johahor
johahor approved these changes Nov 10, 2026
View reviewed changes
Copy link
Member

@johahor johahor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #120 as follow-up.

@johahor
Copy link
Member

johahor commented Nov 10, 2026

I think this PR should resolve #65, and we can open another issue where we describe where we use divs and spans, because they have their real uses. Would appreciate feedback on this

Agree, #65 can be closed by this PR. "No divs or spans" is a simplification: the point is to use semantic elements where one fits, not to avoid div and span completely.

I think a short paragraph in docs/accessibility.md is enough of documentation for this. Could you add this before merging? I'll probably have to give a new approval afterwards..

@martakam
Copy link
Member Author

I'm tired of asking people to approve PRs multiple times. I created #121 to address the documentation.
If everything looks fine to you now, feel free to merge

@martakam martakam linked an issue Nov 10, 2026 that may be closed by this pull request
fix: make the app follow the project's accessibility requirements #65
Closed
@johahor johahor merged commit ee05cb7 into main Nov 10, 2026
@johahor johahor mentioned this pull request Nov 10, 2026
Merged
@martakam martakam mentioned this pull request Nov 10, 2026
Closed
@martakam martakam deleted the fix/accessibility branch November 12, 2026 21:31
Sign in to join this conversation on GitHub.
Reviewers

@johahor johahor johahor approved these changes

Assignees

@martakam martakam

Labels
enhancement New feature or request
Projects
None yet
Milestone
Deliverable 4
Development

Successfully merging this pull request may close these issues.

fix: make the app follow the project's accessibility requirements
2 participants
@martakam @johahor